This repository was archived by the owner on May 5, 2020. It is now read-only.
Add proxy_header capability to websocket protocol#39
Open
luxaritas wants to merge 1 commit intoDesertBus:masterfrom
Open
Add proxy_header capability to websocket protocol#39luxaritas wants to merge 1 commit intoDesertBus:masterfrom
luxaritas wants to merge 1 commit intoDesertBus:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, after looking through this for a good few hours, it looks like the original implementation was fundamentally flawed, and unable to be addressed by #19 - in short, the
self.requestvariable never got set, and the only place I could see to set it would have been inWebSocketsResource.render/_WebSocketsFactory.buildProtocol(as _WebSocketsFactory.buildProtocol would have to accept therequestargument even if it were to be passed on toPeerOverrideFactory.buildProtocol), which didn't seem smart.I'd definitely like to be double checked on my changes here, and if there is a way to make the original implementation work, I'd be down for that (would it make sense to subclass
_WebSocketsFactoryto do this or something?)